Add DCP + Eagle support for Tokenspeed MLA backends#48180
Merged
ywang96 merged 9 commits intoJul 13, 2026
Conversation
Contributor
|
Documentation preview: https://vllm--48180.org.readthedocs.build/en/48180/ |
mergify
Bot
added
documentation
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
Signed-off-by: Pavani Majety <pmajety@nvidia.com>
Signed-off-by: Pavani Majety <pmajety@nvidia.com>
Signed-off-by: Pavani Majety <pmajety@nvidia.com>
Signed-off-by: Pavani Majety <pmajety@nvidia.com>
Signed-off-by: Pavani Majety <pmajety@nvidia.com>
pavanimajety
force-pushed
the
pm/tokenspeed-mla-dcp-eagle
branch
from
1ec0b86 to
2a0a363
Compare
ivanium
approved these changes
Jul 11, 2026
… to TRTLLM TRTLLM context attention has no cross-rank LSE combine, so under DCP it attends only the local interleaved KV shard and produces incorrect prefill output. Restore the DCP guard in use_trtllm_attention (also un-breaks test_use_dcp_fallback), drop the force-TRTLLM-prefill block, and assert the invariant in the TRTLLMPrefill metadata branch. TRTLLM decode under DCP (all-gathered query heads + LSE combine) is unaffected. Co-authored-by: Claude <noreply@anthropic.com> Signed-off-by: Jingyi Yang <girasoley@inferact.ai> Signed-off-by: Jingyi Yang <girasoleyang@gmail.com>
…code trtllm_batch_decode_with_kv_cache has no cp_rank/global-seq-len inputs, so with q_len > 1 its end-aligned causal mask misattends the DCP-interleaved local KV shard (spec token i silently misses up to (W-1)(q_len-1-i) entries, including its own KV on the owner rank). Clamp reorder_batch_threshold to 1 under DCP so spec queries take the DCP-aware prefill path; single-token trtllm-gen DCP decode (all-gathered heads + LSE combine) stays enabled. Mirrors the flashinfer_mla revert already made in this PR and the flashattn_mla precedent (CP-aware kernel args + interleave gate). Co-authored-by: Claude <noreply@anthropic.com> Signed-off-by: Jingyi Yang <girasoleyang@gmail.com>
GirasoleY
reviewed
Jul 11, 2026
GirasoleY
left a comment
GirasoleY
left a comment
Contributor
There was a problem hiding this comment.
Nice! looking forward to this :)
Contributor
|
Opened pavanimajety#5 for inline comments. Currently just fail close on unsupported paths. Feel free to pick the changes that make sense and merge into this. |
[Bugfix] Gate DCP prefill and varlen spec decode on CP-aware paths (for vllm-project#48180)
pavanimajety
requested review from
WoosukKwon,
tlrmchlsmth,
yewentao256 and
zyongye
as code owners
Member
Author
|
Taking a look at the failures. |
pavanimajety
changed the title
Signed-off-by: Pavani Majety <pmajety@nvidia.com>
4 tasks
NickLucche
pushed a commit
to NickLucche/vllm
that referenced
this pull request
Jul 15, 2026
Signed-off-by: Pavani Majety <pmajety@nvidia.com> Signed-off-by: Jingyi Yang <girasoleyang@gmail.com> Co-authored-by: Jingyi Yang <girasoleyang@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Adds support to run DCP + Tokenspeed_MLA with Eagle.
Builds off of https://github.com/vllm-project/vllm/pull/47915/changes
Test Plan
Validated with unit test and Kimi models and the lightseekai-org's two eagle heads.
Test Result
GSM8k is validated.
Perf (Green- this PR, Blue- No DCP) -- validated with Agentic Benchmark:
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.BEFORE SUBMITTING, PLEASE READ https://docs.vllm.ai/en/latest/contributing (anything written below this line will be removed by GitHub Actions)